Fix detection of Bluetooth MIDI devices #25976
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This relaxes constraints on MIDI hardware, added in edd6bb1 My Bluetooth MIDI device has type 0x10002, ie SND_SEQ_PORT_TYPE_MIDI_GENERIC | SND_SEQ_PORT_TYPE_HARDWARE, which doesn't contain the SND_SEQ_PORT_TYPE_PORT flag. Resolves: musescore#19747
Eism
reviewed
Jan 7, 2025
| @@ -77,7 +77,7 @@ MidiDeviceList AlsaMidiInPort::availableDevices() const | |||
|
|
|||
| int streams = SND_SEQ_OPEN_INPUT; | |||
| const unsigned int cap = SND_SEQ_PORT_CAP_SUBS_READ | SND_SEQ_PORT_CAP_READ; | |||
| const unsigned int type_hw = SND_SEQ_PORT_TYPE_PORT | SND_SEQ_PORT_TYPE_HARDWARE; | |||
| const unsigned int type_hw = SND_SEQ_PORT_TYPE_HARDWARE; | |||
| const unsigned int type_sw = SND_SEQ_PORT_TYPE_PORT | SND_SEQ_PORT_TYPE_SOFTWARE; | |||
There was a problem hiding this comment.
Ok, let's remove it for software too and check that MIDI Thgrouh devices are not on the list (I added type filters in this commit edd6bb1)
There was a problem hiding this comment.
I don't have these MDI Thgrouh devices, even without any filter. Can you check yourself ?
After that, should I update this PR, or you will do the flag removal for software too in another commit ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relaxes constraints on MIDI hardware, added in edd6bb1
My Bluetooth MIDI device has type 0x10002, ie
SND_SEQ_PORT_TYPE_MIDI_GENERIC | SND_SEQ_PORT_TYPE_HARDWARE, which doesn't contain the SND_SEQ_PORT_TYPE_PORT flag.
Resolves: #19747